Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGDOCS-2336 #21736

Merged
merged 7 commits into from
Jan 14, 2025
Merged

ENGDOCS-2336 #21736

merged 7 commits into from
Jan 14, 2025

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Jan 8, 2025

Description

Adds tags and improves page descriptions for some admin content

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6e314b8
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/678540da0ad8600008cfc954
😎 Deploy Preview https://deploy-preview-21736--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/extensions Relates to Docker Extensions labels Jan 8, 2025
@aevesdocker aevesdocker marked this pull request as ready for review January 13, 2025 16:38
@aevesdocker aevesdocker requested a review from a team January 13, 2025 16:38
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nit: Not about the update, but related. Update the topic titles to be more unique so it provides more context without the left-nav in the browse by tag list (and search results).
For example, the enterprise deployment FAQ topic just appears as "FAQs" in the browse by tag lists.
https://deploy-preview-21736--docsdocker.netlify.app/tags/admin/
https://deploy-preview-21736--docsdocker.netlify.app/tags/faq/

@aevesdocker
Copy link
Contributor Author

@craig-osterhout good catch. Follow-up incoming

@aevesdocker aevesdocker merged commit 35a1631 into docker:main Jan 14, 2025
14 checks passed
@aevesdocker aevesdocker mentioned this pull request Jan 14, 2025
3 tasks
aevesdocker added a commit that referenced this pull request Jan 16, 2025
<!--Delete sections as needed -->

## Description

Adds better titles to some FAQ pages. Follow-up to
#21736

## Related issues or tickets

<!-- Related issues, pull requests, or Jira tickets -->

## Reviews

<!-- Notes for reviewers here -->
<!-- List applicable reviews (optionally @tag reviewers) -->

- [ ] Technical review
- [ ] Editorial review
- [ ] Product review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/extensions Relates to Docker Extensions area/security status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants